Skip to content

feat: Add OCIDYNAMICROUTINGGATEWAY entity definition (staging)#3064

Open
aprasad-sketch wants to merge 5 commits into
newrelic:mainfrom
aprasad-sketch:feat/oci-ocidynamicroutinggateway-entity
Open

feat: Add OCIDYNAMICROUTINGGATEWAY entity definition (staging)#3064
aprasad-sketch wants to merge 5 commits into
newrelic:mainfrom
aprasad-sketch:feat/oci-ocidynamicroutinggateway-entity

Conversation

@aprasad-sketch

@aprasad-sketch aprasad-sketch commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Add OCI Dynamic Routing Gateway entity definition with synthesis rules, golden metrics, and summary metrics. Staging-only (.stg.yml / Metric.stg.json).

Entity Type

  • Type: INFRA-OCIDYNAMICROUTINGGATEWAY
  • Provider: OCI (Oracle Cloud Infrastructure)
  • Namespace: oci_dynamic_routing_gateway

Synthesis

DRG metrics are emitted per DRG attachment: the resourceId dimension is the attachment OCID (ocid1.drgattachment), while drgOcid is the DRG itself (ocid1.drg). To represent the DRG, synthesis keys on oci.drgOcid (prefix ocid1.drg) rather than the default oci.resourceId. This follows the existing identifier-override precedent used by oci_service_connector_hub (oci.connectorId).

Golden Metrics

  • BytesToDrgAttachment → oci.dynamic.routing.gateway.bytes.to.drg.attachment
  • BytesFromDrgAttachment → oci.dynamic.routing.gateway.bytes.from.drg.attachment
  • PacketDropsToDrgAttachment → oci.dynamic.routing.gateway.packet.drops.to.drg.attachment
  • PacketDropsFromDrgAttachment → oci.dynamic.routing.gateway.packet.drops.from.drg.attachment

Metric Source

https://docs.oracle.com/en-us/iaas/Content/Network/Reference/drgmetrics.htm

entityBot
entityBot previously requested changes Jul 21, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 46, unexpected 'sum(oci.dynamic.routing.gateway.bytes.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 53, unexpected 'sum(oci.dynamic.routing.gateway.packet.drops.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot
entityBot requested a review from a team July 21, 2026 07:08
@entityBot
entityBot dismissed their stale review July 21, 2026 08:39

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 21, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 46, unexpected 'sum(oci.dynamic.routing.gateway.bytes.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 53, unexpected 'sum(oci.dynamic.routing.gateway.packet.drops.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot
entityBot dismissed their stale review July 21, 2026 08:40

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 21, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 46, unexpected 'sum(oci.dynamic.routing.gateway.bytes.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 53, unexpected 'sum(oci.dynamic.routing.gateway.packet.drops.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot
entityBot requested a review from a team July 23, 2026 09:07
mborroni
mborroni previously approved these changes Jul 23, 2026
View reviewed changes
aprasad-sketch and others added 3 commits July 23, 2026 14:09
@aprasad-sketch @claude @mborroni
feat: Add OCIDYNAMICROUTINGGATEWAY entity definition (staging)
657281c 
Add OCI Dynamic Routing Gateway entity definition with:
- Entity definition with synthesis rules (identifier oci.drgOcid, prefix ocid1.drg)
- Golden metrics (bytes to/from DRG, packet drops to/from DRG attachment)
- Summary metrics
- Test data
- Using .stg.yml/.stg.json suffix (staging only)

DRG metrics are emitted per DRG attachment; dimension resourceId is the
attachment OCID and drgOcid is the DRG. Synthesis keys on oci.drgOcid so the
entity represents the DRG. Metric source:
https://docs.oracle.com/en-us/iaas/Content/Network/Reference/drgmetrics.htm

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@aprasad-sketch @mborroni
fix(ocidrg): correct swapped Bytes To/From DRG golden metric titles
a92a163
@aprasad-sketch @mborroni
fix(ocidrg): correct swapped Bytes To/From DRG summary metric titles
79d3858
@mborroni
mborroni force-pushed the feat/oci-ocidynamicroutinggateway-entity branch from c9910f5 to 79d3858 Compare July 23, 2026 12:09
@entityBot
entityBot dismissed stale reviews from dachepallysaikirannewrelic, mborroni, and themself July 23, 2026 12:09

Dismissing reviews

entityBot
entityBot previously requested changes Jul 23, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 46, unexpected 'sum(oci.dynamic.routing.gateway.bytes.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 53, unexpected 'sum(oci.dynamic.routing.gateway.packet.drops.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot
entityBot requested a review from a team July 23, 2026 12:10
@mborroni

mborroni commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

hi @aprasad-sketch could you fix the Entity Bot validation errors? thanks!

@entityBot
entityBot dismissed their stale review July 23, 2026 13:34

Let's validate those changes.

entityBot
entityBot requested changes Jul 23, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 46, unexpected 'sum(oci.dynamic.routing.gateway.bytes.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.bytes.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'SELECT sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 53, unexpected 'sum(oci.dynamic.routing.gateway.packet.drops.from'
  • Error VALIDATING domainType: 'INFRA-OCIDYNAMICROUTINGGATEWAY' on Golden metrics for key 'sum(oci.dynamic.routing.gateway.packet.drops.from.drg.attachment)' - Exception: The NRQL validator was not able to parse the selection.
  • We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@aprasad-sketch @claude
fix: backtick-quote DRG golden metric names (NRQL reserved word 'from')
623743e 
The metric names contain '.from.' (bytes.from / packet.drops.from). 'from' is a
reserved NRQL keyword, so the unquoted metric name fails the golden-metrics NRQL
validator (DiracParserException). Wrap all four metric names in backticks,
matching the existing oci_service_connector_hub golden metrics.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
entityBot
entityBot approved these changes Jul 23, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@aprasad-sketch
aprasad-sketch requested a review from entityBot July 23, 2026 13:42
entityBot
entityBot approved these changes Jul 23, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@entityBot entityBot entityBot approved these changes
@mborroni mborroni mborroni left review comments
+1 more reviewer
@dachepallysaikirannewrelic dachepallysaikirannewrelic dachepallysaikirannewrelic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ARB:not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aprasad-sketch @mborroni @entityBot @dachepallysaikirannewrelic